Skip to content

Conversation

@HyukjinKwon
Copy link
Member

This PR:

  1. Expose get_option, set_option, reset_option to koalas namespace
  2. Add typed values supported by JSON ser/de
  3. Convert max_display_count variable to display.max_rows option.

@softagram-bot
Copy link

Softagram Impact Report for pull/714 (head commit: a998b12)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

⭐ Details of Dependency Changes

details of dependency changes - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #714 into master will increase coverage by 1.77%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
+ Coverage   92.41%   94.18%   +1.77%     
==========================================
  Files          32       32              
  Lines        5548     5559      +11     
==========================================
+ Hits         5127     5236     +109     
+ Misses        421      323      -98
Impacted Files Coverage Δ
databricks/koalas/generic.py 93.71% <ø> (-0.04%) ⬇️
databricks/koalas/series.py 95% <100%> (+0.01%) ⬆️
databricks/koalas/__init__.py 85% <100%> (+8.07%) ⬆️
databricks/koalas/config.py 100% <100%> (ø) ⬆️
databricks/koalas/indexes.py 97.22% <100%> (+0.02%) ⬆️
databricks/koalas/frame.py 94.84% <100%> (+0.01%) ⬆️
databricks/koalas/internal.py 96.29% <0%> (+0.46%) ⬆️
databricks/conftest.py 97.67% <0%> (+4.65%) ⬆️
databricks/koalas/usage_logging/usage_logger.py 100% <0%> (+50%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8360c58...a998b12. Read the comment docs.

@HyukjinKwon
Copy link
Member Author

@ueshin, let me merge this one to unblock #715

@HyukjinKwon HyukjinKwon merged commit 5537d71 into databricks:master Aug 29, 2019
@HyukjinKwon HyukjinKwon deleted the display-max-conf branch November 6, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants