Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Aug 29, 2019

related with #715 i added compute.shorcut_limit

Resolves #715

@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #717 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage    94.4%   94.39%   -0.02%     
==========================================
  Files          32       32              
  Lines        5580     5581       +1     
==========================================
  Hits         5268     5268              
- Misses        312      313       +1
Impacted Files Coverage Δ
databricks/koalas/config.py 100% <ø> (ø) ⬆️
databricks/koalas/frame.py 95.12% <100%> (ø) ⬆️
databricks/koalas/groupby.py 89.9% <100%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b876400...6b0b3c5. Read the comment docs.

@HyukjinKwon
Copy link
Member

Looks good otherwise.

@itholic
Copy link
Contributor Author

itholic commented Aug 31, 2019

@HyukjinKwon Thanks, I've resolved all you commented.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine otherwise. Seems it needs to resolve conflicts

@HyukjinKwon
Copy link
Member

Sorry, it needs to resolve conflicts again.

BTW, if you write Resolves #715 or Closes #715 in the PR description, it will resolve and close the issue #715 automatically when this PR is merged

@itholic
Copy link
Contributor Author

itholic commented Sep 2, 2019

@HyukjinKwon Thank you for the good tips! And The conflicts has fixed.

@HyukjinKwon
Copy link
Member

I added the PR description to show Resolves #715 usage. Also, let's don't cc somebody in PR description. it should only contain things about what this PR proposes.

@itholic
Copy link
Contributor Author

itholic commented Sep 2, 2019

@HyukjinKwon Thanks to comment! and i think maybe we resolve all Add things related with 'compute.shortcut_limit' in #717 . Could you check them out when you available?

@softagram-bot
Copy link

Softagram Impact Report for pull/717 (head commit: 6b0b3c5)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@HyukjinKwon HyukjinKwon merged commit 7de3795 into databricks:master Sep 4, 2019
@itholic itholic deleted the add_config branch September 6, 2019 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert global or limit-related variables into configurations.

4 participants