Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Sep 2, 2019

As you can see in the following screenshot,

There were some missing sql test using Series, so I added it to Doc test.

스크린샷 2019-09-02 오전 11 33 44

could someone check this change maybe if available?

Thanks.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

@codecov-io
Copy link

codecov-io commented Sep 2, 2019

Codecov Report

Merging #733 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage    94.3%   94.32%   +0.01%     
==========================================
  Files          32       32              
  Lines        5570     5570              
==========================================
+ Hits         5253     5254       +1     
+ Misses        317      316       -1
Impacted Files Coverage Δ
databricks/koalas/sql.py 95.83% <ø> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4618def...487558e. Read the comment docs.

@softagram-bot
Copy link

Softagram Impact Report for pull/733 (head commit: 487558e)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@HyukjinKwon HyukjinKwon merged commit 0569c4a into databricks:master Sep 2, 2019
@itholic itholic deleted the test_sql branch September 6, 2019 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants