Add index_col for spark IO reads. #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ueshin , @HyukjinKwon Could you take a look at this maybe if you available? :) |
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
- Coverage 93.83% 93.82% -0.01%
==========================================
Files 32 32
Lines 5744 5753 +9
==========================================
+ Hits 5390 5398 +8
- Misses 354 355 +1
Continue to review full report at Codecov.
|
ueshin
reviewed
Sep 12, 2019
ueshin
reviewed
Sep 13, 2019
itholic
force-pushed
the
add_index_col
branch
from
4b7e673 to
c2ca3b4
Compare
itholic
force-pushed
the
add_index_col
branch
from
1179fe3 to
5eec6b5
Compare
ueshin
reviewed
Sep 13, 2019
Softagram Impact Report for pull/769 (head commit: 0c05081)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
Collaborator
|
Thanks! merging. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Sep 16, 2019
Resolves #765 , I applied the same logic(as worked on #769) to all of the functions mentioned in above issue. So when we work with spark IO read, and also know about index column name, now we can use these functions with index_col like below and avoid creation of default index: ```python >>> ks.read_parquet(path, index_col=['i32', 'i64']) f bhello i32 i64 0 1 6.0 people 1 2 7.0 yo ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related with #765 , I've added index_col for spark IO reads
If we know the index column already, We can prevent the creation of a default index by explicitly typing an index column as function arguments.
For example, now we can use 'read_table' like below.
Currently only added to 'read_table' functions.
And If you think this way is okay, I'm going to create a PR with all the other functions.