-
Notifications
You must be signed in to change notification settings - Fork 367
Add missing method rename for koalas dataframe #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One thing we need to discuss is: |
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
==========================================
- Coverage 94.29% 94.05% -0.25%
==========================================
Files 32 32
Lines 5911 5988 +77
==========================================
+ Hits 5574 5632 +58
- Misses 337 356 +19
Continue to review full report at Codecov.
|
|
@HyukjinKwon @ueshin Ready for review. I leave some discussions in PR description. When these discussion resolved, I will add some edge tests for them. |
|
I discussed about this offline and reviewed roughly @ueshin. Let me leave it to you or I review a day after tomorrow (after my vacation). |
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WeichenXu123 Thanks for working on this! I left some comments.
Btw, pandas supports to rename both index and columns at the same time.
>>> df
A B
0 1 4
1 2 5
2 3 6
>>> df.rename(index={0: 'x', 1: 'y', 2: 'z'}, columns={'A': 'a', 'B': 'b'})
a b
x 1 4
y 2 5
z 3 6Do you have a plan to support this?
|
Updated code to support renaming |
|
Why the codecov failed ? the travis passed. |
|
It fails due to decreasing test coverage (see https://codecov.io/gh/databricks/koalas/compare/9186870f42749382451b14bf15c8723e5d68105d...e1839febd9cdfc896cca8b7f55e24fad8eb910ba/diff) |
ueshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some nits. Otherwise, LGTM.
Softagram Impact Report for pull/806 (head commit: 3cd9394)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
|
Thanks @WeichenXu123 |

Add missing method rename for koalas dataframe.
Some limitation: