Add the base for expanding and rolling in Series, Frame, SeriesGroupby and FrameGroupby #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
reviewed
Sep 30, 2019
Collaborator
ueshin
left a comment
ueshin
left a comment
There was a problem hiding this comment.
Can you add these classes to usage logging?
I guess just adding them to usage_logging/__init__.py should work.
Otherwise, LGTM.
Member
Author
|
Oh sure. Will do. |
Softagram Impact Report for pull/840 (head commit: 4b110a1)⭐ Change Overview
⭐ Details of Dependency Changes
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
Member
Author
|
Thanks @ueshin ! merged. |
Collaborator
|
Sorry that I didn't make clear. Actually we need to the classes too. #855 |
Member
Author
|
Thanks! |
|
Hi, Does the mechanism for aggregating (e.g. mean) after rolling being added sir? |
Member
Author
|
It's not implemented yet. These will be implemented in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
by mimicking pandas class structure.
Partially addresses #807