Skip to content

Conversation

@HyukjinKwon
Copy link
Member

This PR moves the contribution guide at ./CONTRIBUTING.md to our official documentation.
pandas seems doing the similar stuff as well (https://pandas.pydata.org/pandas-docs/stable/development/contributing.html)

@HyukjinKwon HyukjinKwon requested review from rxin and ueshin and removed request for rxin September 28, 2019 14:01
@HyukjinKwon HyukjinKwon force-pushed the move-contributing-guide branch from 603ac7c to b173154 Compare September 30, 2019 23:21
@codecov-io
Copy link

codecov-io commented Sep 30, 2019

Codecov Report

Merging #841 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #841   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files          32       32           
  Lines        6007     6007           
=======================================
  Hits         5657     5657           
  Misses        350      350

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391df25...b173154. Read the comment docs.

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

@HyukjinKwon HyukjinKwon merged commit 1d96eae into databricks:master Oct 4, 2019
@HyukjinKwon
Copy link
Member Author

Merged!

@vgangaprasad
Copy link

This PR moves the contribution guide at ./CONTRIBUTING.md to our official documentation.
pandas seems doing the similar stuff as well (https://pandas.pydata.org/pandas-docs/stable/development/contributing.html)

Hi HyukjinKwon, contributing link is not working, please check (https://koalas.readthedocs.io/en/latest/development/contributing.html)

@vgangaprasad
Copy link

This PR moves the contribution guide at ./CONTRIBUTING.md to our official documentation.
pandas seems doing the similar stuff as well (https://pandas.pydata.org/pandas-docs/stable/development/contributing.html)

Hi HyukjinKwon, contributing link is not working, please check (https://koalas.readthedocs.io/en/latest/development/contributing.html)

Ignore my message, it works, for some reason it didnt work first time. Sorry :(

@HyukjinKwon
Copy link
Member Author

It took a while to build and render. Thanks for double checking this :D.

@HyukjinKwon HyukjinKwon deleted the move-contributing-guide branch November 6, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants