-
Notifications
You must be signed in to change notification settings - Fork 367
Fix Series.__getitem__ to work properly #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #934 +/- ##
==========================================
+ Coverage 94.47% 94.49% +0.01%
==========================================
Files 34 34
Lines 6392 6425 +33
==========================================
+ Hits 6039 6071 +32
- Misses 353 354 +1
Continue to review full report at Codecov.
|
|
Seems like the examples for MultiIndex are different between Koalas and pandas? |
|
@ueshin oops, i think it was just my mistake they actually work same. >>> midx = pd.MultiIndex([['lama', 'cow', 'falcon'],
... ['speed', 'weight', 'length']],
... [[0, 0, 0, 1, 1, 1, 2, 2, 2],
... [0, 1, 2, 0, 1, 2, 0, 1, 2]])
>>> kser = ks.Series([45, 200, 1.2, 30, 250, 1.5, 320, 1, 0.3], index=midx)
>>> pser = kser.to_pandas()
>>> kser['lama']
speed 45.0
weight 200.0
length 1.2
Name: 0, dtype: float64
>>> pser['lama']
speed 45.0
weight 200.0
length 1.2
Name: 0, dtype: float64(fix existing example in PR description also) |
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise.
Softagram Impact Report for pull/934 (head commit: 1ce3226)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |

Resolves #933
For MultiIndex