-
Notifications
You must be signed in to change notification settings - Fork 367
Implement symmetric_difference of Index & MultiIndex #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
==========================================
- Coverage 94.52% 94.43% -0.09%
==========================================
Files 34 34
Lines 6466 6510 +44
==========================================
+ Hits 6112 6148 +36
- Misses 354 362 +8
Continue to review full report at Codecov.
|
Softagram Impact Report for pull/953 (head commit: 35876f8)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
| You can set names of result Index. | ||
| >>> s1.index.symmetric_difference(s2.index, result_name=['a', 'b']) # doctest: +SKIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we skip this @itholic ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HyukjinKwon because the way of print out for MultiIndex are different depends on their python version 😲
|
Seems fine. |
|
Shall we explicitly block the cases |
|
The tests are being failed after this commit anyway. I will revert this commit. @itholic do you mind opening a PR again to address test failures and Takuya's comment above? |
This reverts commit 5c59a82.
|
@HyukjinKwon sure, i'm going to address in separated PR. |

https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Index.symmetric_difference.html#pandas.Index.symmetric_difference
For MultiIndex