Fix bug when assign None to name as Index #974
Conversation
itholic
changed the title
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
==========================================
+ Coverage 94.57% 94.74% +0.16%
==========================================
Files 34 34
Lines 6487 6487
==========================================
+ Hits 6135 6146 +11
+ Misses 352 341 -11
Continue to review full report at Codecov.
|
databricks/koalas/indexes.py
Outdated
| raise ValueError('Names must be a list-like') | ||
| internal = self._kdf._internal | ||
| if len(internal.index_map) != len(names): | ||
|
|
There was a problem hiding this comment.
I would remove this line. Otherwise looks fine cc @ueshin
There was a problem hiding this comment.
oops... i should have double checked that.
Thanks for the comment!
Softagram Impact Report for pull/974 (head commit: b70eac6)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
| .format(len(internal.index_map), len(names))) | ||
| names = [name if isinstance(name, tuple) else (name,) for name in names] | ||
|
|
||
| names = [name if isinstance(name, (tuple, type(None))) else (name,) for name in names] |
There was a problem hiding this comment.
It should usually be is None but isinstance(type(None)) is legitimate too. so I think it's fine.
4 participants
Resolves #971