Fix to_csv for multi-index columns support. #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Softagram Impact Report for pull/983 (head commit: 789d03a)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
ueshin
commented
Oct 31, 2019
| with self.assertRaises(ValueError): | ||
| kdf.to_csv(self.tmp_dir, num_files=1, sep='|', columns=[('x', 'a')]) | ||
|
|
||
| kdf.to_csv(self.tmp_dir, num_files=1, sep='|', header=['a'], columns=[('x', 'a')]) |
Collaborator
Author
There was a problem hiding this comment.
Actually pandas doesn't support columns= ... for multi-index columns.
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
+ Coverage 93.24% 94.76% +1.51%
==========================================
Files 34 34
Lines 6487 6493 +6
==========================================
+ Hits 6049 6153 +104
+ Misses 438 340 -98
Continue to review full report at Codecov.
|
HyukjinKwon
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.