-
Notifications
You must be signed in to change notification settings - Fork 367
Implement min, max, sum and mean of Expanding in Series and DataFrame #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement min, max, sum and mean of Expanding in Series and DataFrame #985
Conversation
5c6c9fa to
e21b76c
Compare
| return partial(property_or_func, self) | ||
| raise AttributeError(item) | ||
|
|
||
| def _apply_as_series_or_frame(self, func): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I maybe separate Expanding into SeriesExpandng and FrameExpanding .. ? not sure yet. pandas seems having Expanding alone.
4debef0 to
e3ef96a
Compare
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
==========================================
- Coverage 94.83% 94.79% -0.05%
==========================================
Files 34 34
Lines 6527 6546 +19
==========================================
+ Hits 6190 6205 +15
- Misses 337 341 +4
Continue to review full report at Codecov.
|
e3ef96a to
0785723
Compare
Softagram Impact Report for pull/985 (head commit: 0785723)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
|
Let me merge this to proceed forward .. I'm still touching the codes around here so please let me know if you guys have more comments. |

This PR implement min, max, sum and mean of Expanding in Series and DataFrame
relates to #984 977