-
Notifications
You must be signed in to change notification settings - Fork 367
Implement expanding.groupby.count in Series and Frame #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 94.79% 93.34% -1.45%
==========================================
Files 34 34
Lines 6568 6601 +33
==========================================
- Hits 6226 6162 -64
- Misses 342 439 +97
Continue to review full report at Codecov.
|
06150ed to
34f952e
Compare
b1dfcdd to
3d4113d
Compare
|
This should be ready for a look. cc @itholic too since you're working on rolling. |
Softagram Impact Report for pull/991 (head commit: 3d4113d)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
|
I'm merging this to proceed forward. I am still touching this file so please let me know if there are some comments. |
|
@HyukjinKwon great! okay i'll start |
|
|
||
| internal = _InternalFrame(sdf=sdf, | ||
| data_columns=[c._internal.data_columns[0] for c in applied], | ||
| index_map=new_index_map) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to preserve column_index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me take a look and fix.

This PR implements
expanding.groupby.countin Series and FrameRelates to #977