Skip to content

Adding New Check: IPv6 Address Validation#578

Merged
mwojtyczka merged 13 commits into
mainfrom
ipv6
Sep 17, 2025
Merged

Adding New Check: IPv6 Address Validation#578
mwojtyczka merged 13 commits into
mainfrom
ipv6

Conversation

@mwojtyczka

@mwojtyczka mwojtyczka commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Changes

Adds checks for the following:

  • Validate IPv6 addresses: is_valid_ipv6_address
  • Check if IPV6 is within a CIDR block: is_ipv6_address_in_cidr
  • Updated required python version to 3.12 to be compatible with test clusters used for automated tests. This requires recreating hatch env locally going forward:
brew install python@3.12
make clean
make dev

Incorporate changes from: #498

Linked issues

Resolves #466

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • added end-to-end tests

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds IPv6 address validation functionality to the codebase, implementing two key validation functions for IPv6 addresses and CIDR block checking. The PR also updates the Python version requirement.

  • Adds IPv6 address validation with is_valid_ipv6_address function
  • Adds IPv6 CIDR block checking with is_ipv6_address_in_cidr function
  • Updates Python version requirement from 3.10 to 3.11

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mwojtyczka mwojtyczka requested a review from ghanse September 16, 2025 17:32
@mwojtyczka mwojtyczka mentioned this pull request Sep 16, 2025
4 tasks
@mwojtyczka mwojtyczka changed the title IPv6 Address Validation New Check: IPv6 Address Validation Sep 16, 2025
@mwojtyczka mwojtyczka changed the title New Check: IPv6 Address Validation Adding New Check: IPv6 Address Validation Sep 16, 2025
@github-actions

github-actions Bot commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

✅ 308/308 passed, 3 flaky, 1 skipped, 2h36m0s total

Flaky tests:

  • 🤪 test_load_checks_from_table_with_unresolved_for_each_column (2.695s)
  • 🤪 test_e2e_workflow (12m59.159s)
  • 🤪 test_e2e_workflow (7m16.363s)

Running from acceptance #2372

## Changes
<!-- Summary of your changes that are easy to understand. Add
screenshots when necessary -->

### Linked issues
<!-- DOC: Link issue with a keyword: close, closes, closed, fix, fixes,
fixed, resolve, resolves, resolved. See
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

Resolves #466 

### Tests
<!-- How is this tested? Please see the checklist below and also
describe any other relevant tests -->

- [x] manually tested
- [x] added unit tests
- [x] added integration tests
- [ ] added end-to-end tests
- [x] added performance tests

---------

Co-authored-by: Marcin Wojtyczka <marcin.wojtyczka@databricks.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/perf/conftest.py Outdated
Comment thread src/databricks/labs/dqx/check_funcs.py
Comment thread src/databricks/labs/dqx/pii/pii_detection_funcs.py
@mwojtyczka mwojtyczka mentioned this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add IPV6 Address Validation

4 participants