Use single lakebase instance for all integration tests and add retry logic#618
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds retry logic to handle workspace quota limits when creating lakebase database instances during integration tests. The change introduces a timeout-based retry mechanism that specifically handles BadRequest exceptions, which commonly occur when the workspace quota for lakebase instances is exceeded during concurrent test runs.
- Added retry logic with 6-minute timeout for lakebase database instance creation
- Refactored database creation into a separate helper function to support retry mechanism
- Removed unused RETRY_INTERVAL_SECONDS constants from test files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/conftest.py | Added retry logic for lakebase database creation and refactored creation into helper function |
| tests/e2e/test_run_demos.py | Removed unused RETRY_INTERVAL_SECONDS constant |
| tests/e2e/conftest.py | Removed unused RETRY_INTERVAL_SECONDS constant |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
✅ 403/403 passed, 2 flaky, 1 skipped, 4h24m17s total Flaky tests:
Running from acceptance #2864 |
Changes
Tests