Skip to content

Use single lakebase instance for all integration tests and add retry logic#618

Merged
mwojtyczka merged 37 commits into
mainfrom
lakebase_storage_retry_db_creation
Oct 18, 2025
Merged

Use single lakebase instance for all integration tests and add retry logic#618
mwojtyczka merged 37 commits into
mainfrom
lakebase_storage_retry_db_creation

Conversation

@mwojtyczka

@mwojtyczka mwojtyczka commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

Changes

  • Create a single lakebase instance for all tests.
  • Implement retry logic in case workspace quota limit for the number of lakebase instances is exceeded.
  • Bumped pytester version.
  • Bumped hatch version to avoid click compatibility issues.

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • added end-to-end tests
  • added performance tests

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds retry logic to handle workspace quota limits when creating lakebase database instances during integration tests. The change introduces a timeout-based retry mechanism that specifically handles BadRequest exceptions, which commonly occur when the workspace quota for lakebase instances is exceeded during concurrent test runs.

  • Added retry logic with 6-minute timeout for lakebase database instance creation
  • Refactored database creation into a separate helper function to support retry mechanism
  • Removed unused RETRY_INTERVAL_SECONDS constants from test files

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/conftest.py Added retry logic for lakebase database creation and refactored creation into helper function
tests/e2e/test_run_demos.py Removed unused RETRY_INTERVAL_SECONDS constant
tests/e2e/conftest.py Removed unused RETRY_INTERVAL_SECONDS constant

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/conftest.py Outdated
Comment thread tests/conftest.py Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/conftest.py Outdated
@github-actions

github-actions Bot commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

✅ 403/403 passed, 2 flaky, 1 skipped, 4h24m17s total

Flaky tests:

  • 🤪 test_quality_checker (3.783s)
  • 🤪 test_e2e_workflow_with_custom_install_folder (7m17.119s)

Running from acceptance #2864

@mwojtyczka mwojtyczka requested a review from alexott October 16, 2025 11:58
bumped pytester version
@mwojtyczka mwojtyczka changed the title Added retry logic for testing lakebase checks storage Use single lakebase instance for all integration tests and add retry logic Oct 17, 2025
@mwojtyczka mwojtyczka mentioned this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants