-
Notifications
You must be signed in to change notification settings - Fork 128
Update handling of metadata columns during schema validation #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3c5aae6
Update handling of metadata columns during schema validation
ghanse 0e8d61b
Update implementation, docs, and tests
ghanse 49624f3
Fix formatting
ghanse 64aa561
Fix implementation and tests
ghanse 36b7dca
Remove cached 'check' attribute during preselection
ghanse 08d235a
Merge branch 'main' into fix_schema_validation
mwojtyczka 8083221
Fix tests
ghanse 02291ea
Refactor
ghanse d2f88ca
Apply suggestion from @mwojtyczka
mwojtyczka 1f92e48
Introduce registry for schema preselection
ghanse f6e7246
Add test coverage for positional and keyword "columns" arguments
ghanse c3f5587
Fmt
ghanse c91c18f
Remove downstreams workflow
ghanse 32a5f14
Merge branch 'main' into fix_schema_validation
ghanse 5115968
Update method signatures and ignore column handling
ghanse ab4df8b
refactor, improved test coverage
mwojtyczka 5a87c5e
Merge branch 'main' into fix_schema_validation
mwojtyczka b6728d8
renamed ignore_columns to exclude_columns
mwojtyczka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.