Skip to content

Allow new lines in sql expression checks #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwojtyczka merged 2 commits into from
Jan 23, 2026
Merged

Allow new lines in sql expression checks #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c431fe
allow new lines in expressions of sql expression check
mwojtyczka Jan 23, 2026
2318e24
removed unused github workflow
mwojtyczka Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 0 additions & 54 deletions .github/workflows/downstreams.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/databricks/labs/dqx/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@


COLUMN_NORMALIZE_EXPRESSION = re.compile("[^a-zA-Z0-9]+")
COLUMN_PATTERN = re.compile(r"Column<'(.*?)(?: AS (\w+))?'>$")
COLUMN_PATTERN = re.compile(r"Column<'(.*?)(?: AS (\w+))?'>$", re.DOTALL)
INVALID_COLUMN_NAME_PATTERN = re.compile(r"[\s,;{}\(\)\n\t=]+")


Expand Down
22 changes: 22 additions & 0 deletions tests/integration/test_apply_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4542,6 +4542,18 @@ def test_apply_checks_with_sql_expression(ws, spark):
"criticality": "error",
"check": {"function": "sql_expression", "arguments": {"expression": "col1 not like \"val%\""}},
},
{
"criticality": "error",
"check": {
"function": "sql_expression",
"arguments": {
# expression with new line
"expression": """col2
not
like \"val%\""""
},
},
},
{
"criticality": "error",
"check": {
Expand Down Expand Up @@ -4580,6 +4592,16 @@ def test_apply_checks_with_sql_expression(ws, spark):
"run_id": RUN_ID,
"user_metadata": {},
},
{
"name": "not_col2_not_like_val",
Comment thread
mwojtyczka marked this conversation as resolved.
"message": "Value is not matching expression: col2 \nnot \n like \"val%\"",
"columns": None,
"filter": None,
"function": "sql_expression",
"run_time": RUN_TIME,
"run_id": RUN_ID,
"user_metadata": {},
},
{
"name": "not_col2_not_like_val",
"message": "Value is not matching expression: col2 not like 'val%'",
Expand Down
Loading