Guard LLM-generated sql_query rules#1275
Merged
mwojtyczka merged 7 commits intoJun 29, 2026
Merged
Conversation
mwojtyczka
reviewed
Jun 26, 2026
mwojtyczka
reviewed
Jun 26, 2026
mwojtyczka
reviewed
Jun 26, 2026
mwojtyczka
requested changes
Jun 26, 2026
mwojtyczka
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR. Generally looking good. Left some comments to address.
Contributor
Author
|
appreciate the thorough review! addressed all three points in the latest push:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
adds SQL safety validation to both LLM-assisted rule generation paths so that any
sql_queryrule containing unsafe SQL (DML/DDL) is dropped before being returned to the caller._filter_unsafe_sql_rules()inllm/llm_core.py: parses the generated JSON rules array and drops any rule whosecheck.functionissql_queryand whosequeryargument failsis_sql_query_safe(), logging a warning with the sanitized query string (CWE-117)DspyRuleGeneration.forward()andDspyRuleUsingDataStats.forward()via anelseclause on the existing JSON-validation block;DspyRuleGenerationWithSchemaInferenceinherits the fix automatically since it delegates toDspyRuleGenerationLinked issues
resolves #1123
Tests
19 unit tests in
tests/unit/test_llm_core.pycovering: safe SELECT queries pass through, unsafe DROP/DELETE/INSERT/TRUNCATE rules are dropped, non-sql_queryrules are unaffected, mixed safe+unsafe batches, null/missingqueryargument, non-array JSON input, malformed rule entries, invalid JSON passthrough, and warning log emission.Documentation and Demos