Add an end-to-end test for the asset bundles demo#533
Merged
Conversation
updated nightly tests
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an end-to-end test for the asset bundles demo to validate the deployment and execution of Databricks asset bundles. The test uses Python's subprocess module to run bundle commands and verifies the complete workflow.
Key changes:
- Added new end-to-end test function that validates, deploys, and runs the asset bundle demo
- Updated asset bundle configuration to support multi-cloud deployment with AWS/Azure targets
- Modified demo notebook to use float values for temperature data and removed manual catalog/schema creation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/test_run_demos.py | Adds end-to-end test function using subprocess to run bundle commands |
| demos/dqx_demo_asset_bundle/databricks.yml | Updates bundle configuration with cloud-specific targets and cluster settings |
| demos/dqx_demo_asset_bundle/dqx_demo_notebook.py | Removes manual catalog/schema creation and converts temperature values to floats |
| demos/dqx_demo_asset_bundle/README.md | Updates documentation to specify target parameter for bundle commands |
| .github/workflows/nightly.yml | Adds Databricks CLI installation and Azure authentication for e2e tests |
| .github/workflows/acceptance.yml | Adds Databricks CLI installation and Azure authentication for e2e tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds an end-to-end test for the asset bundles demo. Bundle commands are run via Python's subprocess module.
Linked issues
Resolves #497
Tests