Skip to content

Add an end-to-end test for the asset bundles demo#533

Merged
mwojtyczka merged 103 commits into
mainfrom
test_demos
Aug 21, 2025
Merged

Add an end-to-end test for the asset bundles demo#533
mwojtyczka merged 103 commits into
mainfrom
test_demos

Conversation

@ghanse

@ghanse ghanse commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

Changes

This PR adds an end-to-end test for the asset bundles demo. Bundle commands are run via Python's subprocess module.

Linked issues

Resolves #497

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • added end-to-end tests

@mwojtyczka mwojtyczka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an end-to-end test for the asset bundles demo to validate the deployment and execution of Databricks asset bundles. The test uses Python's subprocess module to run bundle commands and verifies the complete workflow.

Key changes:

  • Added new end-to-end test function that validates, deploys, and runs the asset bundle demo
  • Updated asset bundle configuration to support multi-cloud deployment with AWS/Azure targets
  • Modified demo notebook to use float values for temperature data and removed manual catalog/schema creation

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/e2e/test_run_demos.py Adds end-to-end test function using subprocess to run bundle commands
demos/dqx_demo_asset_bundle/databricks.yml Updates bundle configuration with cloud-specific targets and cluster settings
demos/dqx_demo_asset_bundle/dqx_demo_notebook.py Removes manual catalog/schema creation and converts temperature values to floats
demos/dqx_demo_asset_bundle/README.md Updates documentation to specify target parameter for bundle commands
.github/workflows/nightly.yml Adds Databricks CLI installation and Azure authentication for e2e tests
.github/workflows/acceptance.yml Adds Databricks CLI installation and Azure authentication for e2e tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/e2e/test_run_demos.py
This was referenced Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add DAB demo to e2e tests

3 participants