Document for private PYPI and Auto Upload dependencies for workspace installation#930
Merged
Conversation
dinbab1984
requested review from
gergo-databricks
and removed request for
a team
Contributor
|
✅ 427/427 passed, 24 flaky, 30 skipped, 3h32m27s total Flaky tests:
Running from acceptance #3185 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
- Coverage 89.91% 89.81% -0.11%
==========================================
Files 60 60
Lines 5184 5221 +37
==========================================
+ Hits 4661 4689 +28
- Misses 523 532 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for installing DQX in workspaces with restricted internet access by enabling automatic upload of dependencies and documenting private PyPI usage.
- Adds
upload_dependenciesconfiguration flag to control automatic dependency uploads during installation - Implements dynamic dependency discovery from package metadata with fallback support
- Documents installation procedures for private PyPI mirrors and offline scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/databricks/labs/dqx/config.py | Adds upload_dependencies boolean field to WorkspaceConfig |
| src/databricks/labs/dqx/installer/config_provider.py | Prompts user about internet access and sets upload_dependencies flag |
| src/databricks/labs/dqx/installer/workflow_installer.py | Implements dependency extraction, discovery, and upload logic |
| docs/dqx/docs/installation.mdx | Documents private PyPI and offline installation procedures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* improved telemetry
mwojtyczka
force-pushed
the
ft/927_support_pr_pypi
branch
from
b1acaa8 to
7faf5d7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Linked issues
This feature addresses #927
Tests