Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Commit d7d04aa

Browse files
author
Sergey Vasilyev
committed
Fix the aftermath of refactoring: moving of parse_table_name() to dialects
1 parent c724ffb commit d7d04aa

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

tests/common.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,8 @@ def setUp(self):
149149
self.table_src_name = f"src{table_suffix}"
150150
self.table_dst_name = f"dst{table_suffix}"
151151

152-
self.table_src_path = self.connection.parse_table_name(self.table_src_name)
153-
self.table_dst_path = self.connection.parse_table_name(self.table_dst_name)
152+
self.table_src_path = self.connection.dialect.parse_table_name(self.table_src_name)
153+
self.table_dst_path = self.connection.dialect.parse_table_name(self.table_dst_name)
154154

155155
drop_table(self.connection, self.table_src_path)
156156
drop_table(self.connection, self.table_dst_path)

tests/test_database.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class TestSchema(unittest.TestCase):
6565
def test_table_list(self):
6666
name = "tbl_" + random_table_suffix()
6767
db = get_conn(self.db_cls)
68-
tbl = table(db.parse_table_name(name), schema={"id": int})
68+
tbl = table(db.dialect.parse_table_name(name), schema={"id": int})
6969
q = db.dialect.list_tables(db.default_schema, name)
7070
assert not db.query(q)
7171

@@ -79,7 +79,7 @@ def test_type_mapping(self):
7979
name = "tbl_" + random_table_suffix()
8080
db = get_conn(self.db_cls)
8181
tbl = table(
82-
db.parse_table_name(name),
82+
db.dialect.parse_table_name(name),
8383
schema={
8484
"int": int,
8585
"float": float,

tests/test_database_types.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -689,8 +689,8 @@ def test_types(self, source_db, target_db, source_type, target_type, type_catego
689689
src_table_name = f"src_{self._testMethodName[11:]}{table_suffix}"
690690
dst_table_name = f"dst_{self._testMethodName[11:]}{table_suffix}"
691691

692-
self.src_table_path = src_table_path = src_conn.parse_table_name(src_table_name)
693-
self.dst_table_path = dst_table_path = dst_conn.parse_table_name(dst_table_name)
692+
self.src_table_path = src_table_path = src_conn.dialect.parse_table_name(src_table_name)
693+
self.dst_table_path = dst_table_path = dst_conn.dialect.parse_table_name(dst_table_name)
694694

695695
start = time.monotonic()
696696
if not BENCHMARK:

tests/test_joindiff.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def test_diff_small_tables(self):
113113
# self.assertEqual(1, self.differ.stats["table2_min_id"])
114114

115115
# Test materialize
116-
materialize_path = self.connection.parse_table_name(f"test_mat_{random_table_suffix()}")
116+
materialize_path = self.connection.dialect.parse_table_name(f"test_mat_{random_table_suffix()}")
117117
mdiffer = self.differ.replace(materialize_to_table=materialize_path)
118118
diff = list(mdiffer.diff_tables(self.table, self.table2))
119119
self.assertEqual(expected, diff)

0 commit comments

Comments
 (0)