Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

fix profile_dir argument overwritten by legacy dir for DBT < 1.3.0 #651

Merged
merged 1 commit into from
Jul 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions data_diff/dbt_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ def __init__(
) -> None:
try_set_dbt_flags()
self.dbt_runner = try_get_dbt_runner()
self.profiles_dir = Path(profiles_dir_override or default_profiles_dir())
self.project_dir = Path(project_dir_override or default_project_dir())
self.connection = {}
self.project_dict = self.get_project_dict()
Expand All @@ -119,6 +118,13 @@ def __init__(
self.threads = None
self.unique_columns = self.get_unique_columns()

if profiles_dir_override:
self.profiles_dir = Path(profiles_dir_override)
elif parse_version(self.dbt_version) < parse_version("1.3.0"):
self.profiles_dir = legacy_profiles_dir()
else:
self.profiles_dir = default_profiles_dir()

def get_datadiff_config(self) -> TDatadiffConfig:
data_diff_vars = self.project_dict.get("vars", {}).get("data_diff", {})
prod_database = data_diff_vars.get("prod_database")
Expand Down Expand Up @@ -211,9 +217,6 @@ def get_run_results_models(self):

dbt_version = parse_version(run_results_obj.metadata.dbt_version)

if dbt_version < parse_version("1.3.0"):
self.profiles_dir = legacy_profiles_dir()

if dbt_version < parse_version(LOWER_DBT_V):
raise DataDiffDbtRunResultsVersionError(
f"Found dbt: v{dbt_version} Expected the dbt project's version to be >= {LOWER_DBT_V}"
Expand Down