Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Revert "mssql normalize_uuid" and fix the overall problem #794

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

dlawin
Copy link
Contributor

@dlawin dlawin commented Dec 6, 2023

normalize_uuid change was just a symptom of problem with mssql's limit_select

  • revert normalize_uuid change
  • fix limit_select for mssql

@dlawin dlawin self-assigned this Dec 6, 2023
@dlawin dlawin requested a review from nolar December 6, 2023 23:17
@pik94
Copy link
Contributor

pik94 commented Dec 7, 2023

@dlawin i approved it just in case not to block if it is a hot fix. But for me it is unclear how uuid normalization breaks it. Could you clarify?

@dlawin dlawin merged commit c320cce into master Dec 8, 2023
@dlawin dlawin deleted the revert-793-mssql_normalize_uuid branch December 8, 2023 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants