Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Resolve failing mssql tests #806

Closed

Conversation

pik94
Copy link
Contributor

@pik94 pik94 commented Dec 19, 2023

This PR affects MSSQL connector

  • Fix timestamp normalization
  • Fix number normalization
  • Partly fix uuid normalization: text UUID are supported, native UUID is turned of

The reason why i decided to exclude native UUID type from the current implementation is casting.
MSSQL UUID values are stored in upper case, whereas other databases generally use lower case. Moreover, when casting MSSQL UUIDs to python UUIDs, we lose upper case, and it leads to incorrect sql query gereration.
For example, we want to compare MSSQL vs PostgreSQL tables with UUID primary keys. For MSSQL a query which calculates md5 hash looks like:

SELECT 
    COUNT(*), 
    MD5(... [col] ...) 
FROM UUID_TABLE 
WHERE ([col] >= 'af8ef74d-9b83-11ee-8e2a-000000000000') AND ([col] < 'af8efd8d-f0d8-6743-ef3c-000000000011')

UUID values in WHERE clause are in lower case after query building, whereas we need upper case for them, and as the result, we have an empty sample in contrast to PostgreSQL.

I have not managed to fix this on the MSSQL connection sidbe, it should be done in the core side.

@pik94 pik94 force-pushed the ilia-dx-1477-resolve-failing-mssql-tests branch from f5c2f5c to 8835e7b Compare December 19, 2023 15:48
@nolar
Copy link
Contributor

nolar commented Jan 2, 2024

Copy link
Contributor

github-actions bot commented Mar 3, 2024

This pull request has been marked as stale because it has been open for 60 days with no activity. If you would like the pull request to remain open, please comment on the pull request and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues/PRs that have gone stale label Mar 3, 2024
Copy link
Contributor

Although we are closing this pull request as stale, it's not gone forever. PRs can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

@github-actions github-actions bot closed this Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale Issues/PRs that have gone stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants