This repository was archived by the owner on May 17, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR affects MSSQL connector
The reason why i decided to exclude native UUID type from the current implementation is casting.
MSSQL UUID values are stored in upper case, whereas other databases generally use lower case. Moreover, when casting MSSQL UUIDs to python UUIDs, we lose upper case, and it leads to incorrect sql query gereration.
For example, we want to compare MSSQL vs PostgreSQL tables with UUID primary keys. For MSSQL a query which calculates md5 hash looks like:
UUID values in
WHERE
clause are in lower case after query building, whereas we need upper case for them, and as the result, we have an empty sample in contrast to PostgreSQL.I have not managed to fix this on the MSSQL connection sidbe, it should be done in the core side.