-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Updated drawer to match entity drawer styling #13665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔴 Meticulous spotted visual differences in 28 of 1492 screens tested: view and approve differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit 057e369. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 5.88kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but let's see if we can reduce/remove the use of !important
margin: 8px 8px 16px 8px; | ||
border-radius: 6px; | ||
padding: 0; | ||
margin: 0 0 4px 0 !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can reduce / remove the use of !important
throughout this file? It could make debugging harder down the road. If we need them to override antd maybe there isn't a way around it but let me know what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!! ill take care of this!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Updated schema drawer:
Tabs
Borders / Dividers
Before