Skip to content

fix(ui/ ingestion): fix double onboarding modals on ingestion page #13709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

purnimagarg1
Copy link
Collaborator

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Jun 6, 2025
Copy link

codecov bot commented Jun 6, 2025

Bundle Report

Changes will decrease total bundle size by 22 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 19.66MB -22 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -22 bytes 16.04MB -0.0%

Files in assets/index-*.js:

  • ./src/app/ingestV2/ManageIngestionPage.tsx → Total Size: 5.0kB

  • ./src/app/ingestV2/source/IngestionSourceList.tsx → Total Size: 15.41kB

Copy link

alwaysmeticulous bot commented Jun 6, 2025

🔴 Meticulous spotted visual differences in 3 of 1531 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit cc9ca68. This comment will update as new commits are pushed.

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...web-react/src/app/ingestV2/ManageIngestionPage.tsx 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@chriscollins3456 chriscollins3456 merged commit 83581dc into master Jun 9, 2025
21 of 23 checks passed
@chriscollins3456 chriscollins3456 deleted the CH-410-bug-fix-double-onboarding-modals branch June 9, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants