feat(resampling): support setting custom dates for the start and end of extrapolation #58
Conversation
tmwly
left a comment
tmwly
left a comment
There was a problem hiding this comment.
lgtm, tested and working - just one comment about release notes
|
Let's go ahead here ? |
…tion with hourly (or shorter) time steps
tmwly
left a comment
tmwly
left a comment
There was a problem hiding this comment.
Overall lgtm
Weirdly, opening a resampling recipe now always dirties the save, which didn't seem to be the case before
Also, maybe we should have a quick sentence explaining what we do in _can_customize_resampling_dates for anyone in a +-13 tz ?
… favoring UTC+13 (NZDT) over UTC-11 (American Samoa), also add a warning about that behavior in the recipe logs
Logged internally as this is common to all plugins with a date input
We now favour UTC+13 and only have unexpected behaviour in UTC-11 (American Samoa). Code is well commented and a warning is added in the logs in that case. |
tmwly
left a comment
tmwly
left a comment
There was a problem hiding this comment.
LGTM! nice work on the timestamp stuff
think we need to merge the changelog but otherwise all clear
Benzhaomin
deleted the
feat/v210-resampling-custom-extrapolation-dates
branch
Default is still to use the first and last known timestamps:
Custom dates can be set for either:
dss-plugin-timeseries-preparation-2.1.0.zip