Skip to content

Feature: validation column config #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Conversation

louisdorard
Copy link
Collaborator

@louisdorard louisdorard commented May 21, 2025

What's changed

New "Feedback columns" section in the visual webapp settings, to configure validation and notes columns. Previously, they needed to be created upstream and to be named in a fixed/specific way, which was impractical and error-prone.

  • "Validation column" setting: tickbox to choose to add a Boolean validation column.
  • Text field to enter a name for this column. This is only a display name to be used in Tabulator. The actual column name will always be validated, and its type will be "boolean_tick".
  • "Notes" column setting. Same idea as the above, with a Textual column. The actual column name will always be notes and its type will be "textarea".

Other improvements:

  • Added a metadata column to the edits datasets: last_edited_by.
  • Added all metadata columns to edited datasets (last_edited_date, last_edited_by, last_action, first_action).
  • Added documentation to replay and apply edits methods

Bug fixes:

  • Fixed bug with boolean editable columns (which includes validation column): missing values were transformed into True!

How to switch to this new version of the plugin

In all projects that use validation columns...

  • In the Visual Webapp: remove previous validation column name from editable columns.
  • In the Flow
    • Change your editlogs to use "validated" instead of the validation column name that was previously used.
    • Remove upstream recipe/step previously used to create a validation column.
    • Build all datasets downstream.
  • In the Visual Webapp: add to settings that validation column is required. Add the display name that you were previously using.

@louisdorard louisdorard requested a review from fabienDaou May 21, 2025 17:49
@louisdorard
Copy link
Collaborator Author

@fabienDaou need your help to update Gherkin tests:

  • Take into account that edits and edited datasets have additional columns.
  • Update edit.reviewed.feature: validation column is now always called validated

@fabienDaou
Copy link
Collaborator

  • Regarding the names of the column, I would make them less prone for conflicts with customers dataset. You could name them: _visual_edit_validated & _visual_edit_notes for ex
  • What do you mean by "Added all metadata columns to edited datasets (last_edited_date, last_edited_by, last_action, first_action)."?

@louisdorard
Copy link
Collaborator Author

  • Smart!
  • I mean that these columns were only found in the edits dataset, but I realized that it would be useful to also have them in the edited dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants