Skip to content

Conversation

@olevski
Copy link
Contributor

@olevski olevski commented Sep 19, 2021

I am trying to use datashim with a public bucket. And this should work (in theory).

After digging around I saw that goofys supports this. However contrary to this commit message it seems that to not use any credentials one can just omit the --profile argument and goofys will figure things out.

I tested this change out and things work now if I use empty strings for the credentials ("").

closes #131

For example this manifest will not work before this PR but works after this change:

apiVersion: com.ie.ibm.hpsys/v1alpha1
kind: Dataset
metadata:
  name: example-public-dataset
spec:
  local:
    type: "COS"
    accessKeyID: ""
    secretAccessKey: ""
    endpoint: "http://s3.amazonaws.com"
    bucket: "giab"
---
apiVersion: v1
kind: Pod
metadata:
  name: test-pod-tasko
spec:
  containers:
  - name: test
    image: ubuntu
    imagePullPolicy: IfNotPresent
    volumeMounts:
    - mountPath: /data
      name: s3bucket
    command: ["sleep", "99999999"]
  volumes:
  - name: s3bucket
    persistentVolumeClaim:
      claimName: example-public-dataset

@olevski olevski force-pushed the use-anonymous-credentials-with-goofys branch from 2718f5b to 9d12f91 Compare September 19, 2021 12:33
@pkoutsov pkoutsov added the enhancement New feature or request label Sep 20, 2021
@pkoutsov pkoutsov added this to the Datashim v0.1.1 milestone Sep 20, 2021
@srikumar003 srikumar003 merged commit f5f376c into datashim-io:master Sep 30, 2021
@srikumar003
Copy link
Collaborator

Tested with minikube and merged. Thanks @olevski !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use public s3 buckets without providing credentials

3 participants