Execute as #3
Merged
Execute as #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not tested yet. Two things I'm left wondering about:
|
Merged
We could use a struct for parameters, that way we can group them into a single type. |
|
Good idea to tap into the
I'm +1 on this approach, in order to make sure we are executing as expected by the api consumer. Feel free to merge when you feel is ready and leave any further improvements for other commits. |
jorgebay
reviewed
Mar 18, 2020
db/db_session.go
Outdated
Comment on lines
55
to
56
| payload := make(map[string][]byte) | ||
| payload["ProxyExecute"] = []byte(userOrRole) |
There was a problem hiding this comment.
NIT: we can use map literal syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.