Move table DDL up to the top level with keyspaces #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpenick
force-pushed
the
refactor_table_ddl
branch
2 times, most recently
from
81b083f to
bc4e70d
Compare
This was referenced Apr 14, 2020
mpenick
force-pushed
the
refactor_table_ddl
branch
from
19e4196 to
1e81d3e
Compare
mpenick
force-pushed
the
refactor_table_ddl
branch
from
18f6b12 to
0314951
Compare
|
Requires: #56 |
|
It's not ideal that stuff schema management stuff is in |
jorgebay
approved these changes
Apr 14, 2020
cmd/server.go
Outdated
| ) | ||
|
|
||
| const defaultGraphQLPath = "/graphql" | ||
| const defaultGraphQLSchemaPath = "/graphql/__schema" |
There was a problem hiding this comment.
Is this notation inspired in graphql's introspection queries __schema: ...?
Do you prefer it to a complete different root, like /graphql-ddl or /graphql-schema-management?
There was a problem hiding this comment.
In any case, you can merge it whenever ready.
mpenick
force-pushed
the
refactor_table_ddl
branch
from
c9a1be2 to
774dc79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.