-
Notifications
You must be signed in to change notification settings - Fork 5
Consider exposing minimal static playground #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could help write the documentation and getting users started... |
This is so cool! 💯 |
We should probably provide a way to disable it. Also, if not on a single keyspace the default URL should start on something other than |
+1
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a quick question.
cmd/server.go
Outdated
// Get the first POST GraphQL route | ||
for _, route := range routes { | ||
if route.Method == http.MethodPost && strings.HasPrefix(route.Pattern, rootPath) { | ||
path = route.Pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this always defaults to: http://localhost:8080/graphql-schema
, which is fine. Is that intended or should this point to a keyspace?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It happens because /graphql-schema
starts with /graphql
...
it's not intended 🤦 , I'll fix it.
I'll rebase this one once #94 is merged, as default endpoint path should be |
I've rebased against master and fixed the default endpoint url issue. There was an issue on the latest version of the playground that included a Also, we have to look out for upcoming changes related to this: https://foundation.graphql.org/news/2020/04/03/web-based-graphql-ides-for-the-win-how-why-playground-graphiql-are-joining-forces/ |
Alright! The best of both world hopefully. |
Minimal static playground using CDN resources: https://github.com/prisma-labs/graphql-playground/blob/master/packages/graphql-playground-html/minimal.html
MIT Licensed.