WIP: Guide compatability with ggplot2 >3.4.2 #270
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Apologies for this cold PR that aims to fix #267. As you may have noticed, ggplot2 has rewritten the guide system, which isn't fully backwards compatible. Unfortunately, this has also broken the interactive guides in ggiraph. This PR implements hybrid versions of the guides, that should be compatible both with current ggplot2 and the development version of ggplot2.
I'm aware that #269 aims to solve the same problem, and the main difference is that this PR has hybrid guides and doesn't solve the
geom_label_interactive()
issue. I'm not too familiar with interactive elements myself, so if somebody could double-check that this PR works as intended with both the CRAN and development versions of ggplot2, that'd be great. Please note that his PR is still work in progress (WIP) as I'm still trying to asses how to preserve as many guide extensions as I reasonably can.Best,
Teun