Skip to content

WIP: Guide compatability with ggplot2 >3.4.2 #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

WIP: Guide compatability with ggplot2 >3.4.2 #270

wants to merge 5 commits into from

Conversation

teunbrand
Copy link
Contributor

Hi there,

Apologies for this cold PR that aims to fix #267. As you may have noticed, ggplot2 has rewritten the guide system, which isn't fully backwards compatible. Unfortunately, this has also broken the interactive guides in ggiraph. This PR implements hybrid versions of the guides, that should be compatible both with current ggplot2 and the development version of ggplot2.

I'm aware that #269 aims to solve the same problem, and the main difference is that this PR has hybrid guides and doesn't solve the geom_label_interactive() issue. I'm not too familiar with interactive elements myself, so if somebody could double-check that this PR works as intended with both the CRAN and development versions of ggplot2, that'd be great. Please note that his PR is still work in progress (WIP) as I'm still trying to asses how to preserve as many guide extensions as I reasonably can.

Best,
Teun

@sigmapi
Copy link
Collaborator

sigmapi commented Jul 9, 2023

Hi @teunbrand and thank you for the PR.
I thought too of using hybrid guides via ggplot's GuideOld.
But in the long run it will be complicated to maintain compatibility for two guide systems, we don't have that much free time. That's ggplot's job not ggiraph's. Imho, the new guide system is better and the way forward.

@teunbrand
Copy link
Contributor Author

Thanks for the response. Please feel free to close this PR if converting to the new guides is the way forward; this PR was more of a suggestion for a transition stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't load ggiraph with dev ggplot2
2 participants