Fix unhandled '*' operator in infer_node #2079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes a crash shown as follows.
reproduction
The above is valid python code, and jedi should not crash.
brief walkthrough
xat line 5x = *xyat line 2_infer_node(context,element)with element is*xywith typestar_expr.star_expr, so it goes to the finalelse: return infer_or_test(context, element)infer_or_testassumes the element is liken1 OP n2 OP n3(link to the code )n1, but the element is*xy, so it ends up inferring the star operatorThe fix is simple, just let star_expr infer to
NO_VALUES.I'm quite new to jedi, so I might miss better fixes. If so I'm happy to revise.
crash logs