Minor build system improvements #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile already computes the gcc plugin directory. Reuse that instead of computing it again.
davidmalcolm
added a commit
that referenced
this pull request
Apr 9, 2012
Minor build system improvements
davidmalcolm
added a commit
that referenced
this pull request
May 4, 2018
davidmalcolm
added a commit
that referenced
this pull request
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have pushed another small round of improvements to my github master branch. The big item is that with the latest Makefile change, it is now possible to use a build gcc other than the one for which the plugin will be loaded. This enables building a plugin that will be used by a cross-compiler. For now, this requires the parent of Make to compute the plugin directory of the target compiler and pass that via GCCPLUGINS_DIR, rather than letting the Makefile compute it. If there is interest, this could be generalized to support running one compiler for computing GCCPLUGINS_DIR and a different compiler for building the native code.
There are also some minor Python3 related changes, which were necessary to get Python3 to parse/optimize all the .py files.