better error handling for broken database.json files #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/config.js
Outdated
Contributor
There was a problem hiding this comment.
You might want to add curly brackets to the if-statement to maintain the conventions in the rest of the code.
Author
There was a problem hiding this comment.
Good point. I added a commit to fix it.
Contributor
|
I've stumbled upon this before, it'll be nice to get a syntax error instead of a confusing (and misleading) error message. |
kunklejr
added a commit
that referenced
this pull request
Feb 7, 2014
better error handling for broken database.json files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left out a comma in my database.json file the first time I tried to run an update. I got an error like:
Cannot find module '/Path/to/Project/Path/to/project/database.json'
which made me think that the problem was with the location of my config file or with node-db-migrate itself. This pull request throws a syntax error if the file is found in the default location but cannot be read. Thanks.