fix(changeColumn): include length in changeColumn #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Son Nguyen <[email protected]>
|
There were the following issues with this Pull Request
|
itssoso
changed the title
wzrdtales
changed the title
|
As per yesterday we also follow the angular convention of naming commits. See db-migrate/node-db-migrate#518 I will include this by myself while merging this time however. Could you also add a test to cover your addition? |
include test case for when length is used in changeColumn relates to #18 Signed-off-by: Son Nguyen <[email protected]>
|
There were the following issues with this Pull Request
|
|
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include length to setType in changeColumn
Signed-off-by: Son Nguyen [email protected]