dbeaver/pro#9588 remove top margin#4405
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
| onClick={onClick} | ||
| > | ||
| {value === null ? <NullFormatter /> : <CheckboxIndicator size="small" checked={value} />} | ||
| {value === null ? <NullFormatter /> : <CheckboxIndicator className="tw:mt-0!" size="small" checked={value} />} |
There was a problem hiding this comment.
checkbox automatically adjusts to the center in every part of the app fine, but something went wrong here:
margin-top: calc(var(--dbv-kit-checkbox-height) * (calc(1 - var(--dbv-kit-checkbox-check-size)) / 2))
maybe delete tw:items-center for the container and fix NullFormatter styles if something is broken for it?
There was a problem hiding this comment.
There should not be margin top on checkbox level and on components in general, margins should be applied in the place of use by parent components of via classname. Otherwise it will break layout
add multiline checkbox story for alignment with text
This reverts commit 0b25ed6.
4 participants
closes 9588