Add support for #[serde(untagged)]
attributes on individual enum variants
#36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By lacking support for
#[serde(untagged)]
attributes on individual enum variants the crate fails to support a common pattern for modeling string-based enums:Deserializing unknown "kind" values as
Kind::Unknown(…)
makesKind
future-proof, which is particularly import in scenarios where one does not control the source providing the serialized representations ofKind
, but also has a requirement to never fail on unexpected values.In the particular scenario above the following would work just fine, as is:
… but there are other scenarios where an enum-level
#[serde(untagged)]
is undesirable, such as if individual "known" variants had additional fields.