Skip to content

fix: tool configuration validation #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agallardol merged 3 commits into from
Dec 29, 2025
Merged

fix: tool configuration validation #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32aaf80
fix: tool config validation
agallardol Dec 24, 2025
cae9176
chore: bump node and app version
agallardol Dec 24, 2025
0e160ec
fix: tool config validation when disable a tool
agallardol Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-ci-healchecks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
env:
ARCH: x86_64-unknown-linux-gnu
OLLAMA_VERSION: v0.12.3
SHINKAI_NODE_VERSION: v1.1.17
SHINKAI_NODE_VERSION: v1.1.18
run: |
npx ts-node ./ci-scripts/download-side-binaries.ts

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ jobs:
env:
ARCH: ${{ matrix.arch }}
OLLAMA_VERSION: v0.12.3
SHINKAI_NODE_VERSION: v1.1.17
SHINKAI_NODE_VERSION: v1.1.18
run: |
npx ts-node ./ci-scripts/download-side-binaries.ts

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ jobs:
- name: Download side binaries
env:
ARCH: ${{ matrix.arch }}
SHINKAI_NODE_VERSION: v1.1.17
SHINKAI_NODE_VERSION: v1.1.18
OLLAMA_VERSION: v0.12.3
run: |
npx ts-node ./ci-scripts/download-side-binaries.ts
Expand Down
6 changes: 3 additions & 3 deletions README.es.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Antes de ejecutar Shinkai, deberá descargar el binario de nodo Shinkai incrusta

```bash
ARCH="aarch64-apple-darwin" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
OLLAMA_VERSION="v0.12.3" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand All @@ -152,15 +152,15 @@ npx ts-node ./ci-scripts/download-side-binaries.ts
```bash
ARCH="x86_64-unknown-linux-gnu" \
OLLAMA_VERSION="v0.12.3" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```

** Windows: **

```powershell
$ENV:OLLAMA_VERSION="v0.12.3"
$ENV:SHINKAI_NODE_VERSION="v1.1.17"
$ENV:SHINKAI_NODE_VERSION="v1.1.18"
$ENV:ARCH="x86_64-pc-windows-msvc"
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand Down
6 changes: 3 additions & 3 deletions README.ja.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Shinkaiを実行する前に、アプリケーションのコア機能を駆動

```bash
ARCH="aarch64-apple-darwin" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
OLLAMA_VERSION="v0.12.3" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand All @@ -152,15 +152,15 @@ npx ts-node ./ci-scripts/download-side-binaries.ts
```bash
ARCH="x86_64-unknown-linux-gnu" \
OLLAMA_VERSION="v0.12.3" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```

** Windows：**

```powershell
$ENV:OLLAMA_VERSION="v0.12.3"
$ENV:SHINKAI_NODE_VERSION="v1.1.17"
$ENV:SHINKAI_NODE_VERSION="v1.1.18"
$ENV:ARCH="x86_64-pc-windows-msvc"
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand Down
6 changes: 3 additions & 3 deletions README.ko.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Shinkai를 실행하기 전에 응용 프로그램의 핵심 기능에 전원을

```bash
ARCH="aarch64-apple-darwin" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
OLLAMA_VERSION="v0.12.3" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand All @@ -152,15 +152,15 @@ npx ts-node ./ci-scripts/download-side-binaries.ts
```bash
ARCH="x86_64-unknown-linux-gnu" \
OLLAMA_VERSION="v0.12.3" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```

** Windows : **

```powershell
$ENV:OLLAMA_VERSION="v0.12.3"
$ENV:SHINKAI_NODE_VERSION="v1.1.17"
$ENV:SHINKAI_NODE_VERSION="v1.1.18"
$ENV:ARCH="x86_64-pc-windows-msvc"
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Before running Shinkai, you'll need to download the embedded Shinkai Node binary

```bash
ARCH="aarch64-apple-darwin" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
OLLAMA_VERSION="v0.12.3" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand All @@ -152,15 +152,15 @@ npx ts-node ./ci-scripts/download-side-binaries.ts
```bash
ARCH="x86_64-unknown-linux-gnu" \
OLLAMA_VERSION="v0.12.3" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```

**Windows:**

```powershell
$ENV:OLLAMA_VERSION="v0.12.3"
$ENV:SHINKAI_NODE_VERSION="v1.1.17"
$ENV:SHINKAI_NODE_VERSION="v1.1.18"
$ENV:ARCH="x86_64-pc-windows-msvc"
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand Down
6 changes: 3 additions & 3 deletions README.zh-HK.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Before running Shinkai, you'll need to download the embedded Shinkai Node binary

```bash
ARCH="aarch64-apple-darwin" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
OLLAMA_VERSION="v0.12.3" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand All @@ -152,15 +152,15 @@ npx ts-node ./ci-scripts/download-side-binaries.ts
```bash
ARCH="x86_64-unknown-linux-gnu" \
OLLAMA_VERSION="v0.12.3" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```

**Windows:**

```powershell
$ENV:OLLAMA_VERSION="v0.12.3"
$ENV:SHINKAI_NODE_VERSION="v1.1.17"
$ENV:SHINKAI_NODE_VERSION="v1.1.18"
$ENV:ARCH="x86_64-pc-windows-msvc"
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand Down
6 changes: 3 additions & 3 deletions README.zh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ npm ci

```bash
ARCH="aarch64-apple-darwin" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
OLLAMA_VERSION="v0.12.3" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand All @@ -152,15 +152,15 @@ npx ts-node ./ci-scripts/download-side-binaries.ts
```bash
ARCH="x86_64-unknown-linux-gnu" \
OLLAMA_VERSION="v0.12.3" \
SHINKAI_NODE_VERSION="v1.1.17" \
SHINKAI_NODE_VERSION="v1.1.18" \
npx ts-node ./ci-scripts/download-side-binaries.ts
```

**视窗：**

```powershell
$ENV:OLLAMA_VERSION="v0.12.3"
$ENV:SHINKAI_NODE_VERSION="v1.1.17"
$ENV:SHINKAI_NODE_VERSION="v1.1.18"
$ENV:ARCH="x86_64-pc-windows-msvc"
npx ts-node ./ci-scripts/download-side-binaries.ts
```
Expand Down
112 changes: 49 additions & 63 deletions apps/shinkai-desktop/src/components/agent/agent-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2337,37 +2337,38 @@ function AgentForm({ mode }: AgentFormProps) {
)}
className="shrink-0"
id={tool.tool_router_key}
onCheckedChange={() => {
onCheckedChange={(checked) => {
const configs =
tool?.config ?? [];
const toolConfigurationNeeded =
const toolConfigurationMissing =
getToolRequiresConfigurations(
configs,
);
if (toolConfigurationNeeded) {
field.onChange(
field.value.includes(
tool.tool_router_key,
)
? field.value.filter(
(value) =>
value !==
tool.tool_router_key,
)
: [
...field.value,
tool.tool_router_key,
],
if (
checked &&
toolConfigurationMissing
) {
toast.error(
'Tool configuration is required',
{
description:
'Please fill in the config required in tool details',
},
);

return;
}
toast.error(
'Tool configuration is required',
{
description:
'Please fill in the config required in tool details',
},

field.onChange(
checked
? [
...field.value,
tool.tool_router_key,
]
: field.value.filter(
(value) =>
value !==
tool.tool_router_key,
),
);
}}
/>
Comment on lines +2364 to 2374

This comment was marked as outdated.

Sign in to view

Expand Down Expand Up @@ -2498,53 +2499,38 @@ function AgentForm({ mode }: AgentFormProps) {
)}
className="shrink-0"
id={tool.tool_router_key}
onCheckedChange={() => {
onCheckedChange={(checked) => {
const configs =
tool?.config ?? [];
const toolConfigurationMissing =
getToolRequiresConfigurations(
configs,
);
if (
configs
.map((conf) => ({
key_name:
conf.BasicConfig
.key_name,
key_value:
conf.BasicConfig
.key_value ?? '',
required:
conf.BasicConfig
.required,
}))
.every(
(conf) =>
!conf.required ||
(conf.required &&
conf.key_value !==
''),
)
checked &&
toolConfigurationMissing
) {
field.onChange(
field.value.includes(
tool.tool_router_key,
)
? field.value.filter(
(value) =>
value !==
tool.tool_router_key,
)
: [
...field.value,
tool.tool_router_key,
],
toast.error(
'Tool configuration is required',
{
description:
'Please fill in the config required in tool details',
},
);

return;
}
toast.error(
'Tool configuration is required',
{
description:
'Please fill in the config required in tool details',
},

field.onChange(
checked
? [
...field.value,
tool.tool_router_key,
]
: field.value.filter(
(value) =>
value !==
tool.tool_router_key,
),
);
}}
/>
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@shinkai/source",
"version": "1.1.27",
"version": "1.1.28",
"license": "SEE LICENSE IN LICENSE",
"files": [
"LICENSE"
Expand Down