Conversation
Used jinja template to generate docker-compose file for multiple nodes start
Support for dynamic IP addr
Rm docker compose and static version container setup files
|
Guanyu Zhang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Pull Request Test Coverage Report for Build 2417666751Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
integration/scenario_test.go
Outdated
|
|
||
| } | ||
|
|
||
| // func killNode(proxyArray []string, nodeNub int, t *testing.T) []string { |
There was a problem hiding this comment.
Is there a reason to keep this commented code ?
There was a problem hiding this comment.
The 2 functions killNode and restartNode are used to test cases where we kill and restart nodes. But in order to pass CI test, we just use the normal scenario test without killing node. We commented those codes to pass lint.
There was a problem hiding this comment.
Commenting code is not the best way to pass lint ... ;)
Please un-comment the code and fix the linting error
There was a problem hiding this comment.
Use this trick
if false {
proxyArray = killNode(proxyArray, 3, t)
restartNode(3, t)
}
and uncomment functions.
There was a problem hiding this comment.
Added new env var KILLNODE to control kill and restart node
Co-authored-by: Noémien Kocher <nkcr.je@gmail.com>
…into guanyu/dockerfiles
integration/scenario_test.go
Outdated
| time.Sleep(time.Second * 5) | ||
|
|
||
| // Kill and restart the node, change false to true when we want to use | ||
| if false { |
There was a problem hiding this comment.
to be replaced by an env variable:
if os.GetEnv("KILL_NODE" == "true")| _, err = io.ReadAll(resp.Body) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
to be removed, if the body is not needed
|
Kudos, SonarCloud Quality Gate passed! |
4 participants
Uh oh!
There was an error while loading. Please reload this page.