Skip to content

Fixes Mobile responsiveness#146

Merged
badrlarhdir merged 8 commits intomainfrom
front-fix-ui
Jun 23, 2022
Merged

Fixes Mobile responsiveness#146
badrlarhdir merged 8 commits intomainfrom
front-fix-ui

Conversation

@badrlarhdir
Copy link
Contributor

@badrlarhdir badrlarhdir commented Jun 22, 2022

  • Add a column in admin/DKGTable.tsx and admin/ProxyRow.tsx
  • Fix electionsTable (only showing icons for quickactions in mobile)
  • Election filter in election/Index.tsx reduces z-index
  • Footer UI responsive
  • ElectionID in election/Show.tsx → break-all (for the long ID)

@badrlarhdir badrlarhdir requested a review from cmsigrist June 22, 2022 07:28
@coveralls
Copy link

coveralls commented Jun 22, 2022

Pull Request Test Coverage Report for Build 2547858942

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 62.271%

Files with Coverage Reduction New Missed Lines %
services/dkg/pedersen/handler.go 13 84.84%
Totals Coverage Status
Change from base Build 2541414999: -0.3%
Covered Lines: 3088
Relevant Lines: 4959

💛 - Coveralls

Copy link
Contributor

@cmsigrist cmsigrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! :D

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward to seeing the result!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@badrlarhdir badrlarhdir merged commit f209da8 into main Jun 23, 2022
@badrlarhdir badrlarhdir deleted the front-fix-ui branch June 23, 2022 08:44
ineiti added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants