Conversation
Pull Request Test Coverage Report for Build 3091068561Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
nkcr
reviewed
Sep 20, 2022
Contributor
nkcr
left a comment
nkcr
left a comment
There was a problem hiding this comment.
Great, thank you. 👍
Just added some minor formatting comments.
README.md
Outdated
| ./setup.sh | ||
| ``` | ||
| With this other script you can choose the number of nodes that you want to set up: | ||
| With this other script using tmux you can choose the number of nodes that you want to set up: |
Contributor
There was a problem hiding this comment.
Be sure to format the lines at 80 chars (In VS code the rewrap plugin can be of a great help):
With this other script using tmux you can choose the number of nodes that you
want to set up:
README.md
Outdated
|
|
||
| 1: Run 3 nodes: | ||
| If you are using Windows and cannot use tmux, you need to do the actions of the | ||
| scripts in point _1_ and _2_ manually: open 3 terminal sessions and run the |
Contributor
There was a problem hiding this comment.
We tend to use *text* for italic, instead of _text_
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small update to the read me to fix a few typos and add indications to launch the system without tmus.
Was way more straight forward than expected 🙈