Skip to content

Changing favicon to D-voting logo#176

Merged
aelalamy42 merged 1 commit intomainfrom
frontend-2022-akelalamy
Oct 5, 2022
Merged

Changing favicon to D-voting logo#176
aelalamy42 merged 1 commit intomainfrom
frontend-2022-akelalamy

Conversation

@aelalamy42
Copy link
Contributor

@aelalamy42 aelalamy42 commented Sep 30, 2022

The favicon (icon on the tab), has been changed from basic react icon to D-Voting logo.

@aelalamy42 aelalamy42 requested a review from nkcr September 30, 2022 14:22
@aelalamy42 aelalamy42 self-assigned this Sep 30, 2022
@CLAassistant
Copy link

CLAassistant commented Sep 30, 2022

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3159463213

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.5%

Totals Coverage Status
Change from base Build 3143684289: 0.0%
Covered Lines: 2364
Relevant Lines: 4041

💛 - Coveralls

@nkcr
Copy link
Contributor

nkcr commented Oct 3, 2022

@aelalamy42 looks ok. You just need to approve the CLA, see the comment.

@aelalamy42
Copy link
Contributor Author

aelalamy42 commented Oct 5, 2022

@nkcr done, waiting for last approval

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚀

@aelalamy42 aelalamy42 merged commit 647e988 into main Oct 5, 2022
@aelalamy42 aelalamy42 deleted the frontend-2022-akelalamy branch October 5, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants