Merged
Conversation
Pull Request Test Coverage Report for Build 3902690141Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
nkcr
suggested changes
Jan 12, 2023
Contributor
nkcr
left a comment
There was a problem hiding this comment.
Thanks!
What happens if we use it without the mocks ? For me we could merge this into main without having the backend ready yet only if we handle the case correctly. For example by displaying "voteID is not a supported feature yet, see isue xxx".
Co-authored-by: Noémien Kocher <nkcr.je@gmail.com>
Co-authored-by: Noémien Kocher <nkcr.je@gmail.com>
https://github.com/dedis/d-voting into 239-verifiability-show-vote-hash-after-casting-a-vote
…ifiability-show-vote-hash-after-casting-a-vote
|
Kudos, SonarCloud Quality Gate passed! |
nkcr
approved these changes
Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








This pull requests aims to address issue #239 and make sure a vote is verifiable on the frontend part. This is possible via a new field sent back when casting a vote that must be added in the backend which is a "Ballot ID", aka a hash of the ballot. Issue #240 must be resolved for this to work.