Skip to content

Issue #239 Verifiability of a vote#265

Merged
aelalamy42 merged 7 commits intomainfrom
239-verifiability-show-vote-hash-after-casting-a-vote
Jan 13, 2023
Merged

Issue #239 Verifiability of a vote#265
aelalamy42 merged 7 commits intomainfrom
239-verifiability-show-vote-hash-after-casting-a-vote

Conversation

@aelalamy42
Copy link
Contributor

This pull requests aims to address issue #239 and make sure a vote is verifiable on the frontend part. This is possible via a new field sent back when casting a vote that must be added in the backend which is a "Ballot ID", aka a hash of the ballot. Issue #240 must be resolved for this to work.

@aelalamy42 aelalamy42 requested a review from a team as a code owner December 29, 2022 14:05
@aelalamy42 aelalamy42 self-assigned this Dec 29, 2022
@aelalamy42 aelalamy42 linked an issue Dec 29, 2022 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Dec 29, 2022

Pull Request Test Coverage Report for Build 3902690141

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 57.421%

Totals Coverage Status
Change from base Build 3902625131: 0.09%
Covered Lines: 3273
Relevant Lines: 5700

💛 - Coveralls

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

What happens if we use it without the mocks ? For me we could merge this into main without having the backend ready yet only if we handle the case correctly. For example by displaying "voteID is not a supported feature yet, see isue xxx".

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@aelalamy42 aelalamy42 requested a review from nkcr January 12, 2023 13:51
@aelalamy42 aelalamy42 merged commit 2e8da23 into main Jan 13, 2023
@aelalamy42 aelalamy42 deleted the 239-verifiability-show-vote-hash-after-casting-a-vote branch January 13, 2023 12:45
@aelalamy42 aelalamy42 restored the 239-verifiability-show-vote-hash-after-casting-a-vote branch January 16, 2023 14:10
@aelalamy42 aelalamy42 deleted the 239-verifiability-show-vote-hash-after-casting-a-vote branch January 16, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verifiability - show vote hash after casting a vote

3 participants