Conversation
emduc
reviewed
Sep 13, 2023
| const ed25519 = curve.newCurve('edwards25519'); | ||
| const priv = ed25519.scalar().pick(); | ||
| const pub = ed25519.point().mul(priv); | ||
| console.log(`PRIVATE_KEY=${priv}`); |
Contributor
There was a problem hiding this comment.
is it normal to simply print them instead of saving them where they are needed?
Member
Author
There was a problem hiding this comment.
The goal here is to create the values that are needed for the .env file, so not to store them anywhere.
Contributor
There was a problem hiding this comment.
maybe add a line saying "please make sure to store this somewhere" as people might indeed expect the values to also be written to a file
Member
Author
There was a problem hiding this comment.
Added an output, but now it won't be usable in scripts anymore...
|
Kudos, SonarCloud Quality Gate passed! |
emduc
approved these changes
Sep 15, 2023
pierluca
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting the keypair generation in typescript.