Skip to content

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Mar 18, 2025

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@xyang16 xyang16 requested review from zachgk and a team as code owners March 18, 2025 00:41
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.76471% with 31 lines in your changes missing coverage. Please review.

Project coverage is 59.74%. Comparing base (8aae174) to head (9ead1b4).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...p/translator/SparseRetrievalServingTranslator.java 61.11% 21 Missing ⚠️
...gingface/translator/SparseRetrievalTranslator.java 91.56% 3 Missing and 4 partials ⚠️
...ace/translator/TextEmbeddingTranslatorFactory.java 66.66% 1 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3642      +/-   ##
============================================
- Coverage     62.05%   59.74%   -2.32%     
+ Complexity     6235     6024     -211     
============================================
  Files           685      694       +9     
  Lines         33508    33963     +455     
  Branches       3572     3627      +55     
============================================
- Hits          20795    20292     -503     
- Misses        11129    12135    +1006     
+ Partials       1584     1536      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xyang16 xyang16 merged commit fe8103c into deepjavalibrary:master Mar 21, 2025
5 checks passed
@xyang16 xyang16 deleted the sparse branch May 9, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants