Skip to content

Fix: Corrected 16-bit PCM normalization to avoid overflow issue #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fix: Corrected 16-bit PCM normalization to avoid overflow issue #3646

merged 1 commit into from
Mar 19, 2025

Conversation

leleZeng
Copy link
Contributor

Description

Brief description of what this PR is about

  • This PR fixes the incorrect normalization of 16-bit PCM samples.
  • Previously, samples were divided by Short.MAX_VALUE (32767), causing -32768 to map slightly below -1.
  • Now, division by 32768.0 ensures all values remain within [-1,1].

@leleZeng leleZeng requested review from zachgk and a team as code owners March 19, 2025 08:38
@leleZeng leleZeng mentioned this pull request Mar 19, 2025
Open
@xyang16 xyang16 merged commit a5443b1 into deepjavalibrary:master Mar 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyang16 xyang16 xyang16 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

+1 more reviewer

@frankfliu frankfliu frankfliu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leleZeng @frankfliu @xyang16