-
Notifications
You must be signed in to change notification settings - Fork 719
[ci] Fixes CI build for cmake 4.0.0 #3659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,4 +1,4 @@ | |||
cmake_minimum_required(VERSION 3.1 FATAL_ERROR) | |||
cmake_minimum_required(VERSION 3.6 FATAL_ERROR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sentencepiece/CMakeLists.txt still using 3.1, we need set env var export CMAKE_POLICY_VERSION_MINIMUM=3.5
in continuous.yml
and native_s3_sentencepiece.yml
diff --git a/.github/workflows/continuous.yml b/.github/workflows/continuous.yml
index 99e72c8db..fe24bff29 100644
--- a/.github/workflows/continuous.yml
+++ b/.github/workflows/continuous.yml
@@ -56,7 +56,9 @@ jobs:
run: brew install libomp
- name: Compile Sentencepiece JNI
if: steps.sentencepiece_changes.outputs.src == 'true'
- run: ./gradlew :extensions:sentencepiece:compileJNI
+ run: |
+ export CMAKE_POLICY_VERSION_MINIMUM=3.5
+ ./gradlew :extensions:sentencepiece:compileJNI
- uses: dorny/paths-filter@v2
id: fasttext_changes
with:
diff --git a/.github/workflows/native_s3_sentencepiece.yml b/.github/workflows/native_s3_sentencepiece.yml
index f37cc1b13..3ae07567f 100644
--- a/.github/workflows/native_s3_sentencepiece.yml
+++ b/.github/workflows/native_s3_sentencepiece.yml
@@ -110,6 +110,7 @@ jobs:
${{ runner.os }}-gradle-
- name: Release JNI prep
run: |
+ export CMAKE_POLICY_VERSION_MINIMUM=3.5
./gradlew :extensions:sentencepiece:compileJNI
./gradlew -Pjni :extensions:sentencepiece:test
- name: Configure AWS Credentials
@@ -56,7 +56,9 @@ jobs: | |||
run: brew install libomp | |||
- name: Compile Sentencepiece JNI | |||
if: steps.sentencepiece_changes.outputs.src == 'true' | |||
run: ./gradlew :extensions:sentencepiece:compileJNI | |||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shell: bash
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3659 +/- ##
============================================
+ Coverage 62.05% 62.41% +0.35%
- Complexity 6235 6311 +76
============================================
Files 685 694 +9
Lines 33508 33963 +455
Branches 3572 3627 +55
============================================
+ Hits 20795 21197 +402
- Misses 11129 11157 +28
- Partials 1584 1609 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Brief description of what this PR is about