Skip to content

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Apr 2, 2025

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@xyang16 xyang16 requested review from zachgk and a team as code owners April 2, 2025 17:29
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1 FATAL_ERROR)
cmake_minimum_required(VERSION 3.6 FATAL_ERROR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentencepiece/CMakeLists.txt still using 3.1, we need set env var export CMAKE_POLICY_VERSION_MINIMUM=3.5 in continuous.yml and native_s3_sentencepiece.yml

diff --git a/.github/workflows/continuous.yml b/.github/workflows/continuous.yml
index 99e72c8db..fe24bff29 100644
--- a/.github/workflows/continuous.yml
+++ b/.github/workflows/continuous.yml
@@ -56,7 +56,9 @@ jobs:
         run: brew install libomp
       - name: Compile Sentencepiece JNI
         if: steps.sentencepiece_changes.outputs.src == 'true'
-        run: ./gradlew :extensions:sentencepiece:compileJNI
+        run: |
+          export CMAKE_POLICY_VERSION_MINIMUM=3.5
+          ./gradlew :extensions:sentencepiece:compileJNI
       - uses: dorny/paths-filter@v2
         id: fasttext_changes
         with:
diff --git a/.github/workflows/native_s3_sentencepiece.yml b/.github/workflows/native_s3_sentencepiece.yml
index f37cc1b13..3ae07567f 100644
--- a/.github/workflows/native_s3_sentencepiece.yml
+++ b/.github/workflows/native_s3_sentencepiece.yml
@@ -110,6 +110,7 @@ jobs:
             ${{ runner.os }}-gradle-
       - name: Release JNI prep
         run: |
+          export CMAKE_POLICY_VERSION_MINIMUM=3.5
           ./gradlew :extensions:sentencepiece:compileJNI
           ./gradlew -Pjni :extensions:sentencepiece:test
       - name: Configure AWS Credentials

@@ -56,7 +56,9 @@ jobs:
run: brew install libomp
- name: Compile Sentencepiece JNI
if: steps.sentencepiece_changes.outputs.src == 'true'
run: ./gradlew :extensions:sentencepiece:compileJNI
run: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    shell: bash

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.41%. Comparing base (8aae174) to head (dac0923).
Report is 14 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3659      +/-   ##
============================================
+ Coverage     62.05%   62.41%   +0.35%     
- Complexity     6235     6311      +76     
============================================
  Files           685      694       +9     
  Lines         33508    33963     +455     
  Branches       3572     3627      +55     
============================================
+ Hits          20795    21197     +402     
- Misses        11129    11157      +28     
- Partials       1584     1609      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xyang16 xyang16 merged commit bebb86a into deepjavalibrary:master Apr 3, 2025
22 checks passed
@xyang16 xyang16 deleted the ci branch May 9, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants